Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mercurial support #5

Merged
merged 7 commits into from
Feb 10, 2018
Merged

Mercurial support #5

merged 7 commits into from
Feb 10, 2018

Conversation

tobiastimm
Copy link
Contributor

This is still WIP.

I really like the idea of this project. I recently added hg support to husky on my own fork, so I wanted to implement the hg part in pretty-quick too.

Like I said this PR is still work in progress, but feel free to comment and share your opinion.

@azz
Copy link
Member

azz commented Jan 12, 2018

This is awesome! I hope I made the SCM API generic enough for this to work, though Mercurial is more similar to git than other SCMs.

Could you also add it to the README.md and add some package.json keywords?

@azz
Copy link
Member

azz commented Jan 21, 2018

Hey @tobiastimm, just wondering what the status of your work is here? Would love to get Mercurial support landed!

@tobiastimm
Copy link
Contributor Author

tobiastimm commented Jan 23, 2018

Hey @azz I was in the hospital last week and still need some time to recover at home. I hope you don't mind it. I will try to implement the mecurial support asap after that.

@azz
Copy link
Member

azz commented Jan 23, 2018

No hurry, was just following up. Take your time and get well first ☺

@tobiastimm
Copy link
Contributor Author

Hey @azz, I've fixed the tests for hg but it's still experimental. I still need to get the time to test it with a real hg repo.

@azz
Copy link
Member

azz commented Feb 9, 2018

Looking good to me. I'm not too familiar with mercurial so I'll defer to your manual testing results.

@tobiastimm
Copy link
Contributor Author

@azz tested it with a local hg repo and fixed some stuff. Should be ready now 😄

@azz azz merged commit fca1264 into prettier:master Feb 10, 2018
@azz
Copy link
Member

azz commented Feb 10, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants